[asterisk-dev] [Code Review]: add test to assert that asterisk replies 481 to an invite with a to-tag

[wdoekes]

> On May 17, 2012, 10:43 a.m., Mark Michelson wrote:
> > /asterisk/trunk/tests/channels/SIP/invite_no_totag/sipp/call.xml, lines 34-58
> > <https://reviewboard.asterisk.org/r/1918/diff/2/?file=27871#file27871line34>
> >
> >     If you use "start_txn" and "ack_txn" do you still have to save the to-tag? Or does that get screwed up since you started the transaction with an invalid to-tag?
> >     
> >     Similarly, could you use [last_To:] instead of having to save the to-tag and [last_Via:] instead of having to save the branch?

You're right: replacing the regexp stuff with simply last_To: and last_Via: produces the same results.

For a normal message, e.g. no to-tag and a 404 as result, asterisk accepts the ACK. For this 481, asterisk doesn't. Removing the to-tag in the ACK doesn't help.


- wdoekes


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1918/#review6237
-----------------------------------------------------------


On May 14, 2012, 4:11 p.m., wdoekes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1918/
> -----------------------------------------------------------
> 
> (Updated May 14, 2012, 4:11 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> I had been meaning to add a check for this, and now that Mark almost broke it with r1911, it was the right time.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/channels/SIP/invite_no_totag/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/invite_no_totag/configs/ast1/sip.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/invite_no_totag/run-test PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/invite_no_totag/sipp/call.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/invite_no_totag/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/tests.yaml 3218 
> 
> Diff: https://reviewboard.asterisk.org/r/1918/diff
> 
> 
> Testing
> -------
> 
> Works with 1.4 and 1.8.
> 
> Note that I did see asterisk attempt to re-send the 481 (not accept the ACK), but I don't think my scenario is wrong.
> 
> 
> Thanks,
> 
> wdoekes
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120517/687b40be/attachment.htm>