[asterisk-dev] [Code Review] UNINIT audit and fixes

[opticron]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1909/#review6193
-----------------------------------------------------------

Ship it!


Good to go.


/branches/1.8/apps/app_page.c
<https://reviewboard.asterisk.org/r/1909/#comment11354>

    I'd argue for using memset here, but that's more personal preference.


- opticron


On May 9, 2012, 12:51 p.m., jrose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1909/
> -----------------------------------------------------------
> 
> (Updated May 9, 2012, 12:51 p.m.)
> 
> 
> Review request for Asterisk Developers, Mark Michelson, rmudgett, and Matt Jordan.
> 
> 
> Summary
> -------
> 
> This patch addresses most of the UNINIT flagged Coverity issues reported in ASTERISK-19652. The ast_clear_flag macro was a major culprit for a number of them due to the use of bitwise and. There are remarks on each of the reports in checklist_UNINIT in the attached Asterisk issue.
> 
> Note:  Coverity specific comments are staying for the time being. This is by the consensus of the dev team since it will make finding these things much easier in the future to properly annotate stuff for Coverity use if that becomes a priority.
> 
> 
> This addresses bug ASTERISK-19652.
>     https://issues.asterisk.org/jira/browse/ASTERISK-19652
> 
> 
> Diffs
> -----
> 
>   /branches/1.8/apps/app_chanspy.c 365630 
>   /branches/1.8/apps/app_disa.c 365630 
>   /branches/1.8/apps/app_page.c 365630 
>   /branches/1.8/funcs/func_cdr.c 365630 
>   /branches/1.8/main/features.c 365630 
> 
> Diff: https://reviewboard.asterisk.org/r/1909/diff
> 
> 
> Testing
> -------
> 
> Tested a little bit for possible garbage values where relevant.
> 
> 
> Thanks,
> 
> jrose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120510/0a90ee4b/attachment-0001.htm>