[asterisk-dev] [Code Review] pass BUILD_CFLGAS and BUILD_LDFLAGS to menuselect (menuselect part)

[Kevin Fleming]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1908/#review6188
-----------------------------------------------------------

Ship it!


Looks good as well.

- Kevin


On May 9, 2012, 9:47 a.m., Tzafrir Cohen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1908/
> -----------------------------------------------------------
> 
> (Updated May 9, 2012, 9:47 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Review 1907 allows passing CFLAGS and LDFLAGS to menuselect. This review is intended to make sure menuselect won't step over them with empty values.
> Furthermore, adding '-c' by default to CFLAGS is not a good idea.
> 
> 
> Diffs
> -----
> 
>   /trunk/Makefile 1032 
> 
> Diff: https://reviewboard.asterisk.org/r/1908/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Tzafrir
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120509/7ad250ee/attachment.htm>