[asterisk-dev] Pinequeue - to hold or not to hold

[Kevin P. Fleming]

On 05/09/2012 09:28 AM, Olle E. Johansson wrote:
> https://reviewboard.asterisk.org/r/1887/
>
> Leif strongly wants to put this on hold, I think it is a great addition as it is and don't think his claim is valid.
>
> I need some consensus on what to do. If the dev team wants to put this on hold, fine, then I won't spend any time on fixing the code according to the rest of the review feedback. If the dev team wants this feature, I will continue to work on it towards a merge into the source code.
>
> I need a decision so I can either continue or close the review, I don't want to have another review that stays out there without feedback for ages, as I actually have pretty good feedback to work on.

I'm not really sure that Leif's concern is a reason to hold off on 
proceeding with this review, but not for the reasons that he stated :-)

With the current app_queue, if the prompt(s) to be played between 
periodic position announcements take more time to play than the period 
of those announcements, then the caller will still hear 'odd' prompts. 
Either the periodic announcement will be played 'late', or it will be 
skipped completely.

With the proposed changes, the periodic announcements would 'stack up' 
if background_prompts is enabled. This would also be 'odd' for the 
caller to hear, but there's a simple solution: the entries in the 
to-be-played queue need to be 'tagged' in some fashion, so that the 
reason why they are in the queue is recorded. Then, when it's time to 
insert a periodic position announcement in the queue, any *existing* 
prompts that are in the queue to produce a periodic position 
announcement can be removed from the queue, and the new position 
announcement prompts take their place. If a set of position announcement 
prompts is already in the queue and playback for them has begun, then 
they'd have to be left in place, and the caller might hear 'you are 
second' immediately followed by 'you are first', but that won't happen 
terribly often.

-- 
Kevin P. Fleming
Digium, Inc. | Director of Software Technologies
Jabber: kfleming at digium.com | SIP: kpfleming at digium.com | Skype: kpfleming
445 Jan Davis Drive NW - Huntsville, AL 35806 - USA
Check us out at www.digium.com & www.asterisk.org