[asterisk-dev] [Code Review]: unchecked_return audit and fixes

[jrose]

> On May 8, 2012, 1:55 p.m., Tilghman Lesher wrote:
> > /branches/1.8/res/ael/ael.flex, lines 878-884
> > <https://reviewboard.asterisk.org/r/1905/diff/1/?file=27759#file27759line878>
> >
> >     Now that I see what this code does, it'd probably be better if this stat were simply replaced with two lseek()s, instead (which is much faster).  The same is true for the earlier case in this file.
> 
> jrose wrote:
>     Yeah, that's true, but optimization isn't really the purpose of this issue.  I'm wouldn't be averse to doing this if ael_parse was something that had to be executed with high frequency, but I don't really think it is.

s/I'm wouldn't/I wouldn't/


- jrose


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1905/#review6172
-----------------------------------------------------------


On May 8, 2012, 12:59 p.m., jrose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1905/
> -----------------------------------------------------------
> 
> (Updated May 8, 2012, 12:59 p.m.)
> 
> 
> Review request for Asterisk Developers and Matt Jordan.
> 
> 
> Summary
> -------
> 
> Makes corrections for a number of unchecked return reports from Coverity and marks a handful of others as being ignorable (because the return seems genuinely inconsequential for these cases).  There are a couple oddities that might need a second look.
> 
> 
> This addresses bug ASTERISK-19658.
>     https://issues.asterisk.org/jira/browse/ASTERISK-19658
> 
> 
> Diffs
> -----
> 
>   /branches/1.8/apps/app_queue.c 365473 
>   /branches/1.8/apps/app_voicemail.c 365473 
>   /branches/1.8/channels/chan_iax2.c 365473 
>   /branches/1.8/channels/chan_sip.c 365473 
>   /branches/1.8/channels/iax2-provision.c 365473 
>   /branches/1.8/channels/sig_analog.c 365473 
>   /branches/1.8/funcs/func_devstate.c 365473 
>   /branches/1.8/funcs/func_lock.c 365473 
>   /branches/1.8/main/acl.c 365473 
>   /branches/1.8/main/asterisk.c 365473 
>   /branches/1.8/main/db.c 365473 
>   /branches/1.8/main/features.c 365473 
>   /branches/1.8/main/pbx.c 365473 
>   /branches/1.8/main/xmldoc.c 365473 
>   /branches/1.8/res/ael/ael.flex 365473 
> 
> Diff: https://reviewboard.asterisk.org/r/1905/diff
> 
> 
> Testing
> -------
> 
> Testing done depends on the particular issue that was being poked at. In some cases, it was as simple as a snap judgement to add a warning. In a couple others, I would test what would happen as a consequence of an unanticipated return.
> 
> 
> Thanks,
> 
> jrose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120508/dac22a10/attachment.htm>