[asterisk-dev] [Code Review] Properly support the d() option in VoiceMail

[opticron]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1892/#review6166
-----------------------------------------------------------

Ship it!


Looks good to me.  Fairly simple change and makes sense.

- opticron


On May 1, 2012, 8:59 p.m., Matt Jordan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1892/
> -----------------------------------------------------------
> 
> (Updated May 1, 2012, 8:59 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> The VoiceMail d() option is documented to do the following:
> 
>     d([c]): Accept digits for a new extension in context <c>, if played
>     during the greeting. Context defaults to the current context.
> 
> This option worked fine if the extension being redirected to existed in the current context of the caller; or, if the context <c> option were used, if the extension being redirected to happened to have an initial digit that also existed in the caller's current context.  If that digit did not happen to exist in the current caller's context, the extension would fail to match.
> 
> This means the following would fail:
> 
> [default]
> 
> exten => 1234,1,VoiceMail(1234 at default,d(othercontext))
> 
> [othercontext]
> 
> exten => 5,1,NoOp(I will never be reached, because there is no extension that begins with a 5 in default)
> 
> This patch fixes it such that if the <c> option is used, the extensions are matched in that context as opposed to the caller's original context.
> 
> 
> This addresses bug ASTERISK-18243.
>     https://issues.asterisk.org/jira/browse/ASTERISK-18243
> 
> 
> Diffs
> -----
> 
>   /branches/1.8/apps/app_voicemail.c 364705 
>   /branches/1.8/main/pbx.c 364705 
> 
> Diff: https://reviewboard.asterisk.org/r/1892/diff
> 
> 
> Testing
> -------
> 
> Testing covered by the leave_voicemail_contexts test, in review 1893.
> 
> 
> Thanks,
> 
> Matt
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120507/56b5993f/attachment.htm>