[asterisk-dev] [Code Review] Extend SIP REFER message originated by Transfer with SIPAddHeader-added headers

[Olle E Johansson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1159/#review6145
-----------------------------------------------------------


I might be confused, but you have removed a lot of headers that won't come back if you disable this functionality. That's not good. Or have I missed something?


/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/1159/#comment11245>

    WHy delete all this code? Are you saying that the user has to add these headers in the dial plan now?


- Olle E


On April 3, 2011, 9:36 p.m., kkm wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1159/
> -----------------------------------------------------------
> 
> (Updated April 3, 2011, 9:36 p.m.)
> 
> 
> Review request for Asterisk Developers, Russell Bryant and Olle E Johansson.
> 
> 
> Summary
> -------
> 
> There is currently no way to augment a REFER message from Transfer with extra headers. The attached patch implements the feature.
> 
> The feature is enabled by default, with a new sip.conf setting to disable it. The rationale for it to be on by default is that it is in fact very controllable from the dialplan: It takes one application call to SIPRemoveHeader with no argument to remove all previously accumulated additional SIP headers. Since Transfer normally terminates the channel, there is no need in practice to keep any SIP headers beyond it in the channel, so that removing these does not impose any dialplan programming complexity.
> 
> A hunk near chan_sip.c line 11697 also fixes an issue with Refer-To header gaining an extra set of <> around the address only when retransmitted due to an authentication request.
> 
> 
> This addresses bug 19059.
>     https://issues.asterisk.org/jira/browse/19059
> 
> 
> Diffs
> -----
> 
>   /trunk/CHANGES 312554 
>   /trunk/channels/chan_sip.c 312554 
>   /trunk/channels/sip/include/sip.h 312554 
>   /trunk/configs/sip.conf.sample 312554 
> 
> Diff: https://reviewboard.asterisk.org/r/1159/diff
> 
> 
> Testing
> -------
> 
> Confirmed working per spec with sip set debug on packet dump.
> 
> Deployed and used on a production server under 1.8.3 and working for 2 weeks already.
> 
> 
> Thanks,
> 
> kkm
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120503/5d7cb543/attachment.htm>