[asterisk-dev] [Code Review]: ICE, STUN, and TURN Support

[Terry Wilson]

> On April 30, 2012, 6:18 p.m., Paul Belanger wrote:
> > /trunk/res/Makefile, lines 71-84
> > <https://reviewboard.asterisk.org/r/1891/diff/1/?file=27605#file27605line71>
> >
> >     I'm defiantly a fan of making this as optional as possible. Simply put, distribution of the pjproject tarball is going to be an issue.  Most operating system have not create packages for it so this will add more burden on the administrator to install the dependency.
> >     
> >     If we can add a ./configure --with-pjproject=/local/path switch giving people the to option link / build with it, that will ease the pain a little too.
> >     
> >     I'm not a fan of adding this as a dependency into asterisk either. But, a contrib script for example might work.
> >     
> >     I know asterisk-scf uses pjproject heavily, how are they working with it?  IIRC, they embedded it right?

Distributions don't usually include pjproject because it isn't designed to be built as a shared library. From what I've seen, projects are supposed to just include it in their tree. Embedding is the only thing that really makes any sense to me.


- Terry


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1891/#review6122
-----------------------------------------------------------


On April 30, 2012, 1:50 p.m., Joshua Colp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1891/
> -----------------------------------------------------------
> 
> (Updated April 30, 2012, 1:50 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This patch adds support for the following:
> 
> ICE attribute parsing and generation in chan_sip
> Usage of the ICE interface in chan_sip
> ICE support within res_rtp_asterisk
> STUN support within res_rtp_asterisk for getting the server reflexive address
> TURN support within res_rtp_asterisk for relaying traffic when needed
> Additional configuration options for the above
> 
> One area which could use some feedback is the pjproject integration. Should we try to use their build system as I have done to integrate things, or try to roll their stuff into ours further?
> 
> If you would like some background on ICE and the actual support here take a gander at the wiki page located at https://wiki.asterisk.org/wiki/display/~jcolp/ICE%2C+STUN%2C+and+TURN+Support - hopefully it proves useful to you.
> 
> 
> Diffs
> -----
> 
>   /trunk/channels/chan_sip.c 361952 
>   /trunk/configs/rtp.conf.sample 361952 
>   /trunk/include/asterisk/rtp_engine.h 361952 
>   /trunk/main/rtp_engine.c 361952 
>   /trunk/res/Makefile 361952 
>   /trunk/res/res_rtp_asterisk.c 361952 
> 
> Diff: https://reviewboard.asterisk.org/r/1891/diff
> 
> 
> Testing
> -------
> 
> Tested various scenarios using Bria and X-Lite behind multiple NATs, different NATs, different internet connections but locally reachable, etc. It works well.
> 
> 
> Thanks,
> 
> Joshua
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120501/02d74429/attachment.htm>