[asterisk-dev] [Code Review] Improve SDP parsing warning messages and RFC compliance

[opticron]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1811/#review5902
-----------------------------------------------------------



/branches/1.8/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/1811/#comment10803>

    This needs to be rephrased.  The non-primary audio stream isn't being ignored, it's causing the entire offer to be rejected.



/branches/1.8/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/1811/#comment10804>

    See above.



/branches/1.8/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/1811/#comment10805>

    See above.



/branches/1.8/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/1811/#comment10806>

    See above.



/branches/1.8/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/1811/#comment10807>

    See above.



/branches/1.8/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/1811/#comment10808>

    See above.



/branches/1.8/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/1811/#comment10809>

    See above.



/branches/1.8/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/1811/#comment10810>

    See above.



/branches/1.8/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/1811/#comment10811>

    Is this now supported properly (and the message just never got removed)?



/branches/1.8/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/1811/#comment10812>

    This can happen if a 'c' line occurs in the non-stream specific area of the SDP since then *sa will be set.  This should probably be left the way it was.


- opticron


On March 23, 2012, 3:34 p.m., Kevin Fleming wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1811/
> -----------------------------------------------------------
> 
> (Updated March 23, 2012, 3:34 p.m.)
> 
> 
> Review request for Asterisk Developers and opticron.
> 
> 
> Summary
> -------
> 
> This patch improves the warning messages generated during SDP parsing when various problems are found:
> 
> * 'Unsupported media type' is only reported when that is in fact the case, not when a supported media type is included in an 'm' line that has an invalid format.
> 
> * All warning messages related to parsing 'm' lines now include the 'm' line contents.
> 
> * (minor bugfix) newline added to port-number-zero warning messages.
> 
> * Warning messages improved to use RFC-specified terminology for various items.
> 
> * Warnings for offers that include more than port for a single media type now include the media type.
> 
> * Nearly all SDP errors will result in a '488 Not Acceptable Here' response, rather than an attempt to use some part of the offer/answer presented in the SDP.
> 
> This patch does *not* correct Asterisk's behavior when a media stream offer with a port number of 0 (zero) is received; that will have to be done in another patch.
> 
> 
> Diffs
> -----
> 
>   /branches/1.8/channels/chan_sip.c 360261 
> 
> Diff: https://reviewboard.asterisk.org/r/1811/diff
> 
> 
> Testing
> -------
> 
> Compile testing only.
> 
> 
> Thanks,
> 
> Kevin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120328/35f278d5/attachment-0001.htm>