[asterisk-dev] [Code Review] Bridge Test - Transfer Callee option (F)

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1830/#review5895
-----------------------------------------------------------



/asterisk/trunk/tests/apps/bridge/bridge_transfer_callee/run-test
<https://reviewboard.asterisk.org/r/1830/#comment10743>

    If this isn't needed, remove it



/asterisk/trunk/tests/apps/bridge/bridge_transfer_callee/run-test
<https://reviewboard.asterisk.org/r/1830/#comment10744>

    Add an errback handler for this originate



/asterisk/trunk/tests/apps/bridge/bridge_transfer_callee/run-test
<https://reviewboard.asterisk.org/r/1830/#comment10745>

    get can return None, which you later pass into a regular expression match.  Even if that doesn't explode, you should be careful and just check for the existence of the 'channel' key in the dictionary before manipulating it.



/asterisk/trunk/tests/apps/bridge/bridge_transfer_callee/run-test
<https://reviewboard.asterisk.org/r/1830/#comment10746>

    And add yet another errback handler here



/asterisk/trunk/tests/apps/bridge/bridge_transfer_callee/run-test
<https://reviewboard.asterisk.org/r/1830/#comment10747>

    What happens if channel is None?  Is that an error?



/asterisk/trunk/tests/apps/bridge/bridge_transfer_callee/run-test
<https://reviewboard.asterisk.org/r/1830/#comment10748>

    And you no longer need start_asterisk or stop_asterisk calls here


- Matt


On March 26, 2012, 11:03 a.m., jrose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1830/
> -----------------------------------------------------------
> 
> (Updated March 26, 2012, 11:03 a.m.)
> 
> 
> Review request for Asterisk Developers, Mark Michelson, Matt Jordan, and pabelnager.
> 
> 
> Summary
> -------
> 
> Bridge Test for F option that was added last week.
> 
> 
> This addresses bug ASTERISK-19282.
>     https://issues.asterisk.org/jira/browse/ASTERISK-19282
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/apps/bridge/bridge_transfer_callee/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/apps/bridge/bridge_transfer_callee/run-test PRE-CREATION 
>   /asterisk/trunk/tests/apps/bridge/bridge_transfer_callee/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/apps/bridge/tests.yaml 3151 
> 
> Diff: https://reviewboard.asterisk.org/r/1830/diff
> 
> 
> Testing
> -------
> 
> Basically the same drill as the baseline test. I ran the test, made sure in the asterisk logs that it hit all the expected extensions, and handled the event checking from there.
> 
> 
> Thanks,
> 
> jrose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120326/1c6ade3c/attachment-0001.htm>