[asterisk-dev] [Code Review] Baseline test for bridge application

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1828/#review5888
-----------------------------------------------------------



/asterisk/trunk/tests/apps/bridge/bridge_baseline/run-test
<https://reviewboard.asterisk.org/r/1828/#comment10725>

    Add an errback to the deferred returned by the originate, and specify the TestCase method handleOriginateFailure.  Sometimes originates fail for funky reasons, and this keeps the whole test from crashing.



/asterisk/trunk/tests/apps/bridge/bridge_baseline/run-test
<https://reviewboard.asterisk.org/r/1828/#comment10726>

    And errback here as well.



/asterisk/trunk/tests/apps/bridge/bridge_baseline/run-test
<https://reviewboard.asterisk.org/r/1828/#comment10727>

    Don't assume the event has the field you need - check to see if 'response' exists in the event first.



/asterisk/trunk/tests/apps/bridge/bridge_baseline/run-test
<https://reviewboard.asterisk.org/r/1828/#comment10728>

    Checking for fields is especially important when it may or may not contain channel values.



/asterisk/trunk/tests/apps/bridge/bridge_baseline/run-test
<https://reviewboard.asterisk.org/r/1828/#comment10729>

    And here as well



/asterisk/trunk/tests/apps/bridge/bridge_baseline/run-test
<https://reviewboard.asterisk.org/r/1828/#comment10730>

    You don't need this anymore



/asterisk/trunk/tests/apps/bridge/bridge_baseline/run-test
<https://reviewboard.asterisk.org/r/1828/#comment10731>

    And you don't need this anymore


- Matt


On March 23, 2012, 1:30 p.m., jrose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1828/
> -----------------------------------------------------------
> 
> (Updated March 23, 2012, 1:30 p.m.)
> 
> 
> Review request for Asterisk Developers, Matt Jordan and pabelganger.
> 
> 
> Summary
> -------
> 
> Baseline test for bridge, Bridges a call and checks to see if a successful bridge event occured.
> 
> Somewhat based on the queue baseline test.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/apps/bridge/bridge_baseline/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/apps/bridge/bridge_baseline/run-test PRE-CREATION 
>   /asterisk/trunk/tests/apps/bridge/bridge_baseline/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/apps/bridge/tests.yaml PRE-CREATION 
>   /asterisk/trunk/tests/apps/tests.yaml 3121 
> 
> Diff: https://reviewboard.asterisk.org/r/1828/diff
> 
> 
> Testing
> -------
> 
> Ran the test a few times, followed what was happening, etc.
> 
> 
> Thanks,
> 
> jrose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120323/b65c3be2/attachment-0001.htm>