[asterisk-dev] [Code Review] Baseline test for bridge application

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1828/#review5883
-----------------------------------------------------------


Mostly good. The only thing I don't like are the timed waits in the dialplan. This is the sort of thing that tends to make tests bounce when they're run by bamboo agents. A better plan is to change the apps in the call1 and call2 contexts to Echo, so that the channels will stay up for as long as necessary. Then in the function where you handle the BridgeExec manager event, you can send an AMI hangup to get the channels to hang up.

While I am recommending the Echo app, I seem to recall Kinsey mentioning something recently about how having two Local channels bridged together and having them both Echo() caused bad things to happen for him. As an alternative, you could use WaitUntil(2100000000) which would mean that the channels would wait until July of 2036. Or you could have them both use Chanspy() and spy on a non-existent channel, just so the channels will stay up until you tell them to hang up from the test.


/asterisk/trunk/tests/apps/bridge/bridge_baseline/run-test
<https://reviewboard.asterisk.org/r/1828/#comment10723>

    This isn't needed since self.passed is set False in __init__


- Mark


On March 23, 2012, 10:33 a.m., jrose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1828/
> -----------------------------------------------------------
> 
> (Updated March 23, 2012, 10:33 a.m.)
> 
> 
> Review request for Asterisk Developers, Matt Jordan and pabelganger.
> 
> 
> Summary
> -------
> 
> Baseline test for bridge, Bridges a call and checks to see if a successful bridge event occured.
> 
> Somewhat based on the queue baseline test.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/apps/bridge/bridge_baseline/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/apps/bridge/bridge_baseline/run-test PRE-CREATION 
>   /asterisk/trunk/tests/apps/bridge/bridge_baseline/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/apps/bridge/tests.yaml PRE-CREATION 
>   /asterisk/trunk/tests/apps/tests.yaml 3121 
> 
> Diff: https://reviewboard.asterisk.org/r/1828/diff
> 
> 
> Testing
> -------
> 
> Ran the test a few times, followed what was happening, etc.
> 
> 
> Thanks,
> 
> jrose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120323/50cdb14f/attachment.htm>