[asterisk-dev] [Code Review] Changes from Mantis ID 13495 in trunk.

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1676/#review5781
-----------------------------------------------------------


All of the released branches of Asterisk including trunk use the 1.0 branch of libss7.  This patch depends upon libss7 trunk and a patch you have done for libss7.  It is my understanding that the trunk branch of libss7 is in an incomplete state and has not been worked on in quite a while.

This patch needs updating because of changes in trunk.


trunk/channels/chan_dahdi.c
<https://reviewboard.asterisk.org/r/1676/#comment10582>

    Update the Doxygen comments since these are no longer boolean.



trunk/channels/chan_dahdi.c
<https://reviewboard.asterisk.org/r/1676/#comment10585>

    CODING GUIDELINES: Always use curly braces.  Please go through your patch and add them where you add or modify existing lines.
    
    You don't have to fix formatting in lines you don't need to change.



trunk/channels/sig_ss7.h
<https://reviewboard.asterisk.org/r/1676/#comment10587>

    This is never initialized and is likely no longer needed with recent changes to sig_ss7.



trunk/channels/sig_ss7.h
<https://reviewboard.asterisk.org/r/1676/#comment10580>

    Update the Doxygen comments to reflect that it is no longer a boolean.



trunk/channels/sig_ss7.h
<https://reviewboard.asterisk.org/r/1676/#comment10581>

    Get rid of this flag.  Use call_level instead.  The call_level value represents the call state and eliminated the proceeding and alerting flags.



trunk/channels/sig_ss7.h
<https://reviewboard.asterisk.org/r/1676/#comment10588>

    This redirecting information should also be put into the ast_channel.redirecting.from structure.  The redirecting information is accessed by the REDIRECTING dialplan function.  Other channel technologies (SIP and ISDN) use the ast_channel.redirecting information instead of channel variables.
    
    Outgoing calls should prefer the data in the ast_channel.redirecting.from structure instead of the SS7 channel technology specific channel variable.



trunk/channels/sig_ss7.h
<https://reviewboard.asterisk.org/r/1676/#comment10589>

    This could be made a boolean bit field.



trunk/channels/sig_ss7.c
<https://reviewboard.asterisk.org/r/1676/#comment10594>

    Curly brace position.



trunk/channels/sig_ss7.c
<https://reviewboard.asterisk.org/r/1676/#comment10595>

    Why was linkset->ss7 changed to p->ss7->ss7?  They should be the same.



trunk/channels/sig_ss7.c
<https://reviewboard.asterisk.org/r/1676/#comment10591>

    The following three switch statements are inconsistently formatted.  CODING GUIDELINES



trunk/channels/sig_ss7.c
<https://reviewboard.asterisk.org/r/1676/#comment10590>

    This is always true since it is an array.



trunk/channels/sig_ss7.c
<https://reviewboard.asterisk.org/r/1676/#comment10593>

    This should be static.



trunk/channels/sig_ss7.c
<https://reviewboard.asterisk.org/r/1676/#comment10592>

    This information should be obtained from the sig_ss7_indicate():AST_CONTROL_CONNECTED_LINE and ast_channel.connected.id.  Dialplan accesses these values using the CONNECTEDLINE function.  Continuing to add SS7 specific channel variables is not recommended.  See sig_pri for usage.


- rmudgett


On Feb. 14, 2012, 4:54 a.m., KNK wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1676/
> -----------------------------------------------------------
> 
> (Updated Feb. 14, 2012, 4:54 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> chan_dahdi / sig_ss7 part of changes
> 
> 
> This addresses bug SS7-27.
>     https://issues.asterisk.org/jira/browse/SS7-27
> 
> 
> Diffs
> -----
> 
>   trunk/channels/chan_dahdi.c 351501 
>   trunk/channels/sig_ss7.h 351501 
>   trunk/channels/sig_ss7.c 351501 
> 
> Diff: https://reviewboard.asterisk.org/r/1676/diff
> 
> 
> Testing
> -------
> 
> compiles, link setup, cli commands, bassic calls
> Passed my phone calls through local SS7 loop for few days without problems
> 
> 
> Thanks,
> 
> KNK
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120308/677511ff/attachment-0001.htm>