[asterisk-dev] [Code Review] Opaquify remaining fields and move struct ast_channel into main/channel_internal_api.c

[Terry Wilson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1786/
-----------------------------------------------------------

(Updated March 9, 2012, 3:54 p.m.)


Review request for Asterisk Developers.


Changes
-------

Address some of rmudgett's concerns, and make things work with REF_DEBUG, etc.


Summary
-------

This should finish up the first stage of opaquification.


Diffs (updated)
-----

  /trunk/main/channel.c 358725 
  /trunk/main/channel_internal_api.c 358725 
  /trunk/apps/app_channelredirect.c 358725 
  /trunk/apps/app_chanspy.c 358725 
  /trunk/apps/app_confbridge.c 358725 
  /trunk/apps/app_dial.c 358725 
  /trunk/apps/app_disa.c 358725 
  /trunk/apps/app_dumpchan.c 358725 
  /trunk/apps/app_externalivr.c 358725 
  /trunk/apps/app_followme.c 358725 
  /trunk/apps/app_macro.c 358725 
  /trunk/apps/app_mixmonitor.c 358725 
  /trunk/apps/app_parkandannounce.c 358725 
  /trunk/apps/app_queue.c 358725 
  /trunk/apps/app_speech_utils.c 358725 
  /trunk/apps/app_stack.c 358725 
  /trunk/apps/app_talkdetect.c 358725 
  /trunk/bridges/bridge_multiplexed.c 358725 
  /trunk/channels/chan_agent.c 358725 
  /trunk/channels/chan_bridge.c 358725 
  /trunk/channels/chan_dahdi.c 358725 
  /trunk/channels/chan_local.c 358725 
  /trunk/channels/chan_phone.c 358725 
  /trunk/channels/chan_sip.c 358725 
  /trunk/channels/chan_unistim.c 358725 
  /trunk/channels/chan_vpb.cc 358725 
  /trunk/channels/sig_analog.c 358725 
  /trunk/include/asterisk/channel.h 358725 
  /trunk/main/app.c 358725 
  /trunk/main/autoservice.c 358725 
  /trunk/main/bridging.c 358725 
  /trunk/main/cli.c 358725 
  /trunk/main/features.c 358725 
  /trunk/main/file.c 358725 
  /trunk/main/indications.c 358725 
  /trunk/main/manager.c 358725 
  /trunk/main/pbx.c 358725 
  /trunk/main/rtp_engine.c 358725 
  /trunk/res/res_agi.c 358725 
  /trunk/res/res_musiconhold.c 358725 
  /trunk/res/snmp/agent.c 358725 

Diff: https://reviewboard.asterisk.org/r/1786/diff


Testing
-------

unit tests pass. I think I ran the testsuite on it last night and it passed. I'm running it again right now just to make sure.


Thanks,

Terry

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120309/554fb541/attachment.htm>