[asterisk-dev] [Code Review] Don't strip :port from Transfer(user at address:port)

[Joshua Colp]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1790/#review5766
-----------------------------------------------------------

Ship it!


Well that was easy...

- Joshua


On March 2, 2012, 3:43 p.m., jrose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1790/
> -----------------------------------------------------------
> 
> (Updated March 2, 2012, 3:43 p.m.)
> 
> 
> Review request for Asterisk Developers, Mark Michelson and Matt Jordan.
> 
> 
> Summary
> -------
> 
> For some reason, we would just shave the port information out of the string and never make any use of it. This patch changes it so that we don't bother to cut the port out of the domain name.  As far as I can tell, there is no reason to since we don't use the domain name for anything other than building the To Header.
> 
> 
> This addresses bug ASTERISK-19321.
>     https://issues.asterisk.org/jira/browse/ASTERISK-19321
> 
> 
> Diffs
> -----
> 
>   /branches/1.8/channels/chan_sip.c 357956 
> 
> Diff: https://reviewboard.asterisk.org/r/1790/diff
> 
> 
> Testing
> -------
> 
> Tried transfering to the following:
> 
> exten => 021,1,Transfer(101 at 10.24.18.246:5080)
> 
> with and without the patch.  Without the patch, it fails without specifying a port in the To header.  With, it successfully connected the call.
> 
> 
> Thanks,
> 
> jrose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120308/d2c2f52a/attachment.htm>