[asterisk-dev] [Code Review] Update to review 1160

[Terry Wilson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1804/
-----------------------------------------------------------

(Updated March 7, 2012, 2:47 p.m.)


Review request for Asterisk Developers and Tilghman Lesher.


Changes
-------

Move an if.


Summary
-------

This basically just addresses tilghman's last comment on review 1160 since that review stalled. It also adds a check for columns that that we don't know about, so that if we are doing an INSERT, we don't complain about empty values for columns like auto-incremented ids, etc.

The checks for wide characters should probably be backported to 1.8+ since recent mysql odbc connectors throw a bunch of warnings becauase the varchar types end up being used.


This addresses bug ASTERISK-17548.
    https://issues.asterisk.org/jira/browse/ASTERISK-17548


Diffs (updated)
-----

  /trunk/cel/cel_odbc.c 358575 
  /trunk/configs/cel_odbc.conf.sample 358575 

Diff: https://reviewboard.asterisk.org/r/1804/diff


Testing
-------

Installed odbc stuff and mysql/postgres and set up CEL. I didn't see any problems.


Thanks,

Terry

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120307/61115e97/attachment.htm>