[asterisk-dev] [Code Review] Reimplement 'skip' property for testsuite

[Paul Belanger]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1796/#review5743
-----------------------------------------------------------



asterisk/trunk/lib/python/asterisk/TestConfig.py
<https://reviewboard.asterisk.org/r/1796/#comment10524>

    Kinda ugly, but helps us avoid adding new parsing logic in AsteriskVersion()



asterisk/trunk/runtests.py
<https://reviewboard.asterisk.org/r/1796/#comment10523>

    Now that I see this, ast_version is not even used. Will fix



asterisk/trunk/tests/channels/SIP/message_auth/test-config.yaml
<https://reviewboard.asterisk.org/r/1796/#comment10525>

    An example of how to skip branches.  Since 1.4 and 1.6.2 are security mode, and ending some what soon(tm).  I suggest we make this change and only have 1.8 as our base now.
    
    If we still want 1.4 / 1.6.2, I suggest we branch the testsuite then.


- Paul


On March 6, 2012, 11:02 a.m., Paul Belanger wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1796/
> -----------------------------------------------------------
> 
> (Updated March 6, 2012, 11:02 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> I'm looking for some initial feedback on the following patch.  Since we have the digiumphones branch now, we need to rework on the testsuite handles asterisk versions.  Before we used minversion / maxversion (which worked across branches) however this does not work well if you have a parallel branch.
> 
> So, I've removed them in favour of 'skip'.  Basically, the testsuite will run on every version of asterisk unless you have 'skip' defined, then depending on the flag (right now branch) it checks to run or skip the test.
> 
> We currently use the 'skip' flag, but only for a basic check.  At the moment to skip broken tests, this new method would give us more control on the type of tests to skip.  EG: Skip if OS is FreeBSD or skip if arch is i386.
> 
> 
> Diffs
> -----
> 
>   asterisk/trunk/lib/python/asterisk/TestConfig.py 3083 
>   asterisk/trunk/lib/python/asterisk/version.py 3083 
>   asterisk/trunk/runtests.py 3083 
>   asterisk/trunk/tests/channels/SIP/message_auth/test-config.yaml 3083 
> 
> Diff: https://reviewboard.asterisk.org/r/1796/diff
> 
> 
> Testing
> -------
> 
> Local dev box.
> 
> There is also more work needed to be done in updating the test-config.yaml files, however I want to get this patch reviewed before making all those changes.
> 
> 
> Thanks,
> 
> Paul
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120306/297e5a72/attachment.htm>