[asterisk-dev] [Code Review] chan_dahdi: Add dialtone_detect option

[Jeremy Pepper]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1737/
-----------------------------------------------------------

(Updated March 5, 2012, 4:18 p.m.)


Review request for Asterisk Developers.


Changes
-------

The patch is the same as the last revision. I've updated the description to use the updated 'dialtone_detect' option name, and I've updated the testing section to provide more information on how to trigger the problem this patch corrects.


Summary (updated)
-------

chan_dahdi: Add dialtone_detect option

This adds an option to chan_dahdi.conf called dialtone_detect. This can be set like this:

    dialtone_detect = yes ; Watch for dialtone for 10 seconds after answer
    dialtone_detect = always ; Watch for dialtone for the whole call
    dialtone_detect = 5000 ; Watch for dialtone for 5000ms

If dialtone is detected on an inbound call, Asterisk will hang up the channel.


This addresses bug ASTERISK-19316.
    https://issues.asterisk.org/jira/browse/ASTERISK-19316


Diffs
-----

  trunk/channels/chan_dahdi.c 358216 
  trunk/configs/chan_dahdi.conf.sample 358216 

Diff: https://reviewboard.asterisk.org/r/1737/diff


Testing (updated)
-------

This patch has been installed on an Asterisk box connected to another Asterisk box simulating an upstream carrier. Testing was done with dialtone_detect off, set to always, set to yes, and set to a custom value.

Here's the relevant dialplan on the receiving side:

[from-pstn]
exten => s,1,Wait(5)
exten => s,n,Answer
exten => s,n,MusicOnHold
exten => s,n,Hangup

To trigger the issue this fixes, place a call to the test box, then hang up any time between when you see "Starting simple switch on 'DAHDI/1-1'" and when the call is answered.


Thanks,

Jeremy

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120305/40783fea/attachment.htm>