[asterisk-dev] [Code Review] Create STACK_PEEK to view calling context, extension, and priority

[Tilghman Lesher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1776/
-----------------------------------------------------------

(Updated March 4, 2012, 3:53 a.m.)


Review request for Asterisk Developers.


Changes
-------

Fixes some of the points I raised in my own review.


Summary
-------

The issue in question wants variables similar to how Macro worked, which presented variables in the dialplan to denote the calling context, extension, and priority.  This might be similarly set by AEL, except that AEL doesn't have the information to pass at the right time.  It has the information before the call to Gosub is made, but it needs to be passed into the Gosub, so it can be saved on the stack (and thus correctly disappear, restoring previous values, when Return is executed.  Thus, STACK_PEEK was born, with the intention of being able to mimic features in 1.4's AEL that are not present anymore.

Whether this goes into a version of Asterisk earlier than 11 is a case for the bug reporter to make.


This addresses bug ASTERISK-19336.
    https://issues.asterisk.org/jira/browse/ASTERISK-19336


Diffs (updated)
-----

  /trunk/utils/conf2ael.c 358080 
  /trunk/utils/ael_main.c 358080 
  /trunk/tests/test_gosub.c 358080 
  /trunk/res/ael/pval.c 358080 
  /trunk/funcs/func_dialplan.c 358080 
  /trunk/apps/app_stack.c 358080 

Diff: https://reviewboard.asterisk.org/r/1776/diff


Testing
-------

Added test cases to test_gosub, in the process discovering another bug that has since been fixed.  Works as designed.


Thanks,

Tilghman

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120304/66693de4/attachment.htm>