[asterisk-dev] [Code Review] Add F option from dial to app_queue

[jrose]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1785/
-----------------------------------------------------------

(Updated March 1, 2012, 9:10 a.m.)


Review request for Asterisk Developers, Mark Michelson and rmudgett.


Changes
-------

Richard's review comments.


Summary
-------

This adds the F option from dial to queue.  The idea is pretty simple.

If F is enabled, if the caller has connected to a queue member and hangs up, the queue member who was called will stay active and go to the indicated context/extension/priority.

If no arguments are set for F, then the called member will jump to the next priority as with Dial.


This addresses bug ASTERISK-19283.
    https://issues.asterisk.org/jira/browse/ASTERISK-19283


Diffs (updated)
-----

  /trunk/apps/app_queue.c 357541 

Diff: https://reviewboard.asterisk.org/r/1785/diff


Testing
-------

exten => 013,1,Answer()
exten => 013,2,Set(_crunchbar=chocorice)
exten => 013,n,NoOp(_crunchbar=${crunchbar})
exten => 013,n,Queue(markq,F())
exten => 013,n,Playback(tt-weasels)
exten => 013,n,NoOp(_crunchbar=${crunchbar})

Tested to see if the member would be directed to Playback(tt-weasels) and then properly display the crunchbar variable which was documented as being supposed to be copied.

Also:

exten => 014,1,Answer()
exten => 014,n,Set(_licorice=yuck)
exten => 014,n,NoOp(_licorice=${licorice})
exten => 014,n,Queue(markq,F(queuetestcontext^001^1))
exten => 014,n,NoOp(Goldfishes \(love you\))

[queuetestcontext]
exten => 001,1,NoOp()
exten => 001,n,Playback(tt-weasels)
exten => 001,n,NoOp(_licorice=${licorice})

To make sure it worked with all the arguments for F.


Thanks,

jrose

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120301/132cb87f/attachment-0001.htm>