[asterisk-dev] [Code Review]: Opaquify some ast_channel typedefs, file descriptor arrays, and the _softhangup flag

[Terry Wilson]

Nope, not forgotten, it's just not committed with the rest of the patch. It should be in with the code for the next review I have posted, though.

----- Original Message -----
> From: "Damien Wedhorn" <voip at facts.com.au>
> To: "Asterisk Developers Mailing List" <asterisk-dev at lists.digium.com>
> Sent: Friday, March 2, 2012 2:14:50 PM
> Subject: Re: [asterisk-dev] [Code Review]: Opaquify some ast_channel typedefs, file descriptor arrays, and the
> _softhangup flag
> 
> 
> On 02/03/12 09:04, Terry Wilson wrote:
> 
> 
> 
> 	This is an automatically generated e-mail. To reply, visit:
> 	https://reviewboard.asterisk.org/r/1784/
> 
> 
> 
> 
> On March 1st, 2012, 12:05 a.m., wedhorn wrote:
> 
> Apart from the above, it appears there's only a single use for
> softhangup_internal_flag_set in ast_do_masquerade (line 6651 of
> channel.c). While I appreciate it's a bit off topic for your patch,
> does anyone actually see a reason for removing all of the
> _softhangup flags before setting it to AST_SOFTHANGUP_DEV? If not,
> this could be changed to flag_add and flag_set be removed. The
> softhangup flag in general is a big mess. Nothing is supposed to set
> it directly, but everything does and you can't use the existing
> setter function without breaking things. There is a lot of stuff
> that needs to happen with that code. And yes. That should definitely
> just be an add. It might have been changed manually before I looked
> at that and said "hell, no...we're adding an _add() function." :-)
> Terry, you seem to have forgotten to correct line 7733 of chan_dahdi
> to a softhangup_internal_flag_add before committing.
> 
> Damien
> 
> 
> --
> _____________________________________________________________________
> -- Bandwidth and Colocation Provided by http://www.api-digital.com --
> 
> asterisk-dev mailing list
> To UNSUBSCRIBE or update options visit:
>    http://lists.digium.com/mailman/listinfo/asterisk-dev