[asterisk-dev] [Code Review]: Add IPv6 Address Support To Security Events Framework

[elguero]

> On Feb. 29, 2012, 10:08 a.m., Simon Perreault wrote:
> > /trunk/channels/chan_sip.c, line 3445
> > <https://reviewboard.asterisk.org/r/1777/diff/1/?file=25104#file25104line3445>
> >
> >     Why is this new check necessary?
> 
> elguero wrote:
>     Without this check, a warning message is generated saying to remove localaddr and/or externaddr settings.  But, we can't do that if we are supporting both IPv4 and IPv6.  We still need NAT functionality on IPv4 addresses, unless I am doing something wrong.  Therefore, if I am doing udpbindaddr=::, this message is a bit of a nuisance.
>     
>     Unless there is a better way?
> 
> Simon Perreault wrote:
>     Understood, but how is this related to the security events framework?

You are right... it isn't really related.  I guess I was trying to take care of two birds with one stone.  It should probably go under another issue that way it can be possibly applied to the current branches since that message will appear there as well I believe.


- elguero


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1777/#review5675
-----------------------------------------------------------


On Feb. 29, 2012, 11:58 a.m., elguero wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1777/
> -----------------------------------------------------------
> 
> (Updated Feb. 29, 2012, 11:58 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> The current API supports only IPv4 for security events. 
> 
> *  This patch changes the API to support IPv6 and updates the components that use this API.
> 
> *  It quiets a warning that is being displayed if binding to IPv6 and IPv4 ( udpbindaddr=:: ). 
> 
> *  It also eliminates an error that was being generated since the current implementation was treating an IPv6 socket address as if it was IPv4.
> 
> *  Some copyright dates were updated as well.
> 
> 
> This addresses bug ASTERISK-19447.
>     https://issues.asterisk.org/jira/browse/ASTERISK-19447
> 
> 
> Diffs
> -----
> 
>   /trunk/CHANGES 357541 
>   /trunk/channels/chan_sip.c 357541 
>   /trunk/channels/sip/security_events.c 357541 
>   /trunk/include/asterisk/security_events_defs.h 357541 
>   /trunk/main/manager.c 357541 
>   /trunk/main/security_events.c 357541 
> 
> Diff: https://reviewboard.asterisk.org/r/1777/diff
> 
> 
> Testing
> -------
> 
> Tested SIP implementation on CentOS 5.7, connected with IPv4 clients and IPv6 clients.  Also tested SIP on Fedora 16 vm with IPv4.  Security log now shows IPv4 or IPv6 addresses when a security event is generated.
> 
> 
> Thanks,
> 
> elguero
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120301/52d70888/attachment.htm>