[asterisk-dev] [Code Review] SDP Media Attribute Interface + H.263/H.264 Format Attribute Modules

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2005/#review6589
-----------------------------------------------------------

Ship it!


I'm giving a "ship it" due to the testing you said you've done. I'd feel better if there were unit tests added to ensure that SDP is parsed and generated properly.


/trunk/res/res_format_attr_h264.c
<https://reviewboard.asterisk.org/r/2005/#comment12498>

    redness



/trunk/res/res_format_attr_silk.c
<https://reviewboard.asterisk.org/r/2005/#comment12499>

    your code is blushing


- Mark


On June 27, 2012, 7:52 a.m., Joshua Colp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2005/
> -----------------------------------------------------------
> 
> (Updated June 27, 2012, 7:52 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This patch adds to the format attribute interface two methods used to parse and generate SDP for formats. It also adds two format attribute modules - one for H.263 and one for H.264. The SDP logic for CELT and SILK have also been moved to their respective format attribute modules.
> 
> 
> Diffs
> -----
> 
>   /trunk/channels/chan_sip.c 368849 
>   /trunk/include/asterisk/format.h 368849 
>   /trunk/main/format.c 368849 
>   /trunk/main/translate.c 368849 
>   /trunk/res/res_format_attr_celt.c 368849 
>   /trunk/res/res_format_attr_h263.c PRE-CREATION 
>   /trunk/res/res_format_attr_h264.c PRE-CREATION 
>   /trunk/res/res_format_attr_silk.c 368849 
> 
> Diff: https://reviewboard.asterisk.org/r/2005/diff
> 
> 
> Testing
> -------
> 
> Performed heavy testing of H.263 and H.264 format attribute modules using various softphones and different scenarios.
> 
> 
> Thanks,
> 
> Joshua
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120627/1bd4ae13/attachment.htm>