[asterisk-dev] [Code Review] Add the ability to set flags via the config options api

Mark Michelson reviewboard at asterisk.org
Wed Jun 27 09:06:59 CDT 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2004/#review6584
-----------------------------------------------------------

Ship it!


Indeed!

- Mark


On June 26, 2012, 7:27 p.m., Terry Wilson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2004/
> -----------------------------------------------------------
> 
> (Updated June 26, 2012, 7:27 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Allows the setting of flags via the config options api.
> For example, code like this:
> 
> #define OPT1 1 << 0
> #define OPT2 1 << 1
> #define OPT3 1 << 2
> 
> struct thing {
>    unsigned int flags;
> };
> 
> and a config like this:
> 
> [blah]
> opt1=yes
> opt2=no
> opt3=yes
> 
> 
> Diffs
> -----
> 
>   /trunk/configs/config_test.conf.sample 369417 
>   /trunk/include/asterisk/config_options.h 369417 
>   /trunk/main/config_options.c 369417 
>   /trunk/tests/test_config.c 369417 
> 
> Diff: https://reviewboard.asterisk.org/r/2004/diff
> 
> 
> Testing
> -------
> 
> I wrote a test, and that passes.
> 
> 
> Thanks,
> 
> Terry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120627/baef33ee/attachment-0001.htm>


More information about the asterisk-dev mailing list