[asterisk-dev] [Code Review] Add Expires header to SIP PUBLISH responses
Mark Michelson
reviewboard at asterisk.org
Tue Jun 26 17:21:39 CDT 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2003/#review6581
-----------------------------------------------------------
Ship it!
Looks good to me!
- Mark
On June 25, 2012, 10:50 p.m., gareth wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2003/
> -----------------------------------------------------------
>
> (Updated June 25, 2012, 10:50 p.m.)
>
>
> Review request for Asterisk Developers.
>
>
> Summary
> -------
>
> Successful (ie: 200 OK) responses to SIP PUBLISH requests need to have an Expires header as per RFC 3903 section 6.6.
>
> This patch adds SIP_PUBLISH to the list of methods that need an Expires header added in respprep().
>
>
> Diffs
> -----
>
> /trunk/channels/chan_sip.c 369389
>
> Diff: https://reviewboard.asterisk.org/r/2003/diff
>
>
> Testing
> -------
>
> It compiles.
>
>
> Thanks,
>
> gareth
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120626/2ef1abd4/attachment.htm>
More information about the asterisk-dev
mailing list