[asterisk-dev] [Code Review]: Correct message array allocation issues in app_voicemail

[opticron]

> On June 22, 2012, 11:57 a.m., Mark Michelson wrote:
> > branches/1.8/apps/app_voicemail.c, lines 8029-8039
> > <https://reviewboard.asterisk.org/r/1994/diff/2/?file=29022#file29022line8029>
> >
> >     There's an access to vms->dh_arraysize here without a lock held.

Fixed.


- opticron


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1994/#review6553
-----------------------------------------------------------


On June 20, 2012, 3:18 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1994/
> -----------------------------------------------------------
> 
> (Updated June 20, 2012, 3:18 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This patch reworks the handling of array allocation and freeing to ensure that freed memory is not used.
> 
> 
> This addresses bug AST-894.
>     https://issues.asterisk.org/jira/browse/AST-894
> 
> 
> Diffs
> -----
> 
>   branches/1.8/apps/app_voicemail.c 368806 
> 
> Diff: https://reviewboard.asterisk.org/r/1994/diff
> 
> 
> Testing
> -------
> 
> Poked through voicemail manually.  Testing has been performed on issue ASTERISK-19923 and seems to have corrected the segfault in that case.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120625/3115c558/attachment.htm>