[asterisk-dev] [Code Review]: Bring the (missing) changes from Mantis ID 13495 in trunk.

KNK reviewboard at asterisk.org
Fri Jun 22 04:00:29 CDT 2012



> On June 21, 2012, 2:04 p.m., Matt Jordan wrote:
> > As Richard mentioned on https://reviewboard.asterisk.org/r/1676, releases of libss7 are currently only made from the 1.0 branch.  Unfortunately, trunk of libss7 is not in a state that releases can be made from it.
> > 
> > As such, both this patch and the one on https://reviewboard.asterisk.org/r/1676 will need to be re-worked for the 1.0 branch.  If you need some assistance in getting that done, let us know in #asterisk-dev and we can try to help you get the patches refactored for that branch.

Should not be a problem, as the only difference in (ex) trunk from 1.0 is the ss7_add_link by name instead of fd for which i have created a wrapper to keep the old style in Asterisk, so no changes to 1676 should be needed.

I think the patch can still be applied to the new-API branch without the wrapper function, so it will still be of some help :)


- KNK


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1653/#review6538
-----------------------------------------------------------


On June 4, 2012, 9:40 a.m., KNK wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1653/
> -----------------------------------------------------------
> 
> (Updated June 4, 2012, 9:40 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> libss7 part of the changes.
> Added additional cause codes, Transmission Medium Requirement setting and connected line to CPG messages + code cleanup.
> 
> 
> This addresses bugs SS7-27, SS7-52 and SS7-53.
>     https://issues.asterisk.org/jira/browse/SS7-27
>     https://issues.asterisk.org/jira/browse/SS7-52
>     https://issues.asterisk.org/jira/browse/SS7-53
> 
> 
> Diffs
> -----
> 
>   trunk/isup.h 296 
>   trunk/isup.c 296 
>   trunk/libss7.h 296 
>   trunk/mtp2.h 296 
>   trunk/mtp2.c 296 
>   trunk/mtp3.h 296 
>   trunk/mtp3.c 296 
>   trunk/ss7.c 296 
>   trunk/ss7_internal.h 296 
> 
> Diff: https://reviewboard.asterisk.org/r/1653/diff
> 
> 
> Testing
> -------
> 
> compiles, link setup, cli commands, bassic calls, connected line and redirection
> 
> 
> Thanks,
> 
> KNK
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120622/4e7219cc/attachment.htm>


More information about the asterisk-dev mailing list