[asterisk-dev] [Code Review] Add "stun show status" command to the CLI

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2001/#review6547
-----------------------------------------------------------


One last thing, then this is looking good.


/trunk/res/res_stun_monitor.c
<https://reviewboard.asterisk.org/r/2001/#comment12364>

    Some versions of gcc will emit a warning about mixing declarations and code with this here.  Ideally, this would make the most sense on line 405, before this method is called.
    
    Then, the method can be defined as:
    
    static void _stun_show_status(int fd)
    
    It doesn't need to return anything, since it doesn't have a mechanism by which it can fail.


- Matt


On June 21, 2012, 6:34 p.m., jkister wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2001/
> -----------------------------------------------------------
> 
> (Updated June 21, 2012, 6:34 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Add "stun show status" to the CLI
> 
> https://issues.asterisk.org/jira/browse/ASTERISK-18046
> 
> 
> Diffs
> -----
> 
>   /trunk/res/res_stun_monitor.c 369180 
> 
> Diff: https://reviewboard.asterisk.org/r/2001/diff
> 
> 
> Testing
> -------
> 
> stable for over 9 months. tested on 1.8, 10.4, 10.5
> 
> 
> Thanks,
> 
> jkister
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120622/76ef3409/attachment-0001.htm>