[asterisk-dev] [Code Review] Add chan_dahdi Who Hung Up? implementation for analog and PRI/ISDN

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1953/#review6546
-----------------------------------------------------------



trunk/channels/sig_pri.c
<https://reviewboard.asterisk.org/r/1953/#comment12363>

    The cause[] and cause_str[] char arrays could be declared once at the top plenty large enough for any reasonable string.


- rmudgett


On June 21, 2012, 9:11 a.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1953/
> -----------------------------------------------------------
> 
> (Updated June 21, 2012, 9:11 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This adds Who Hung Up? implementations for analog (not all that useful) and PRI/ISDN DAHDI technologies.
> 
> 
> This addresses bug SWP-4222.
>     https://issues.asterisk.org/jira/browse/SWP-4222
> 
> 
> Diffs
> -----
> 
>   trunk/channels/sig_analog.c 369180 
>   trunk/channels/sig_pri.c 369180 
> 
> Diff: https://reviewboard.asterisk.org/r/1953/diff
> 
> 
> Testing
> -------
> 
> Ran calls through analog and PRI/ISDN to ensure that cause codes were showing up where expected and that the HANGUPCAUSE hash was being updated as expected.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120621/78065abf/attachment.htm>