[asterisk-dev] [Code Review]: Add cause reporting to sig_ss7 for chan_dahdi

[rmudgett]

> On June 21, 2012, 11:51 a.m., rmudgett wrote:
> > trunk/channels/sig_ss7.c, line 1301
> > <https://reviewboard.asterisk.org/r/1955/diff/2/?file=29087#file29087line1301>
> >
> >     This might not be dimensioned large enough.
> 
> opticron wrote:
>     Actually, it's too big.  Dropped to 30.

There is no need to be that stingy with the array size.  The string that you are putting in here is coming from libss7 so extra space is better than not enough.


- rmudgett


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1955/#review6533
-----------------------------------------------------------


On June 21, 2012, 3:32 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1955/
> -----------------------------------------------------------
> 
> (Updated June 21, 2012, 3:32 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This adds HANGUPCAUSE hash reporting to the SS7 technology for chan_dahdi.
> 
> 
> This addresses bug SWP-4222.
>     https://issues.asterisk.org/jira/browse/SWP-4222
> 
> 
> Diffs
> -----
> 
>   trunk/channels/sig_ss7.c 369180 
> 
> Diff: https://reviewboard.asterisk.org/r/1955/diff
> 
> 
> Testing
> -------
> 
> Tested with a SS7 link connected between two machines.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120621/d4d2bc26/attachment-0001.htm>