[asterisk-dev] [Code Review] logger: Call ID logging phase III part 1 split - chan_iax2 and chan_dahdi

[jrose]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1927/
-----------------------------------------------------------

(Updated June 20, 2012, 4:27 p.m.)


Review request for Asterisk Developers, rmudgett and Matt Jordan.


Changes
-------

Adds sig_ss7 linkset thread changes similar to those in the last patch for sig_pri's dchannel.

I'm much less certain on this than sig_pri on account of having no idea what the cases here actually are doing, but the worst case is that it binds a callid uselessly anyway, so no harm no fowl.

Some of the cases will start a new call (IAM for instance)... I'm not 100% sure how this will work in that case, but if I had to guess, the callid won't be bound because the channel used to bind with won't have a call id or the owner just won't exist and so the callid will instead be created at the beginning of the start_call function like it would have anyway.

On the other hand, if a callid were bound and a new call were starting, that would probably be bad, so those cases (anything involving ss7_start_call) are worth looking at.


Summary
-------

split from: https://reviewboard.asterisk.org/r/1886/
These changes allow channels dahdi and iax2 to set callids and bind log messages to callids.

This is the same code as in the earlier review.  It was split to commit the approved parts and to hopefully encourage some review of the remaining parts since there is less in here to review now.


Diffs (updated)
-----

  /trunk/channels/chan_dahdi.c 369042 
  /trunk/channels/chan_agent.c 369042 
  /trunk/channels/chan_iax2.c 369042 
  /trunk/channels/chan_local.c 369042 
  /trunk/channels/sig_analog.c 369042 
  /trunk/channels/sig_pri.c 369042 
  /trunk/channels/sig_ss7.c 369042 
  /trunk/main/autoservice.c 369042 
  /trunk/main/bridging.c 369042 
  /trunk/main/logger.c 369042 
  /trunk/main/pbx.c 369042 

Diff: https://reviewboard.asterisk.org/r/1927/diff


Testing
-------

see https://reviewboard.asterisk.org/r/1886/


Thanks,

jrose

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120620/abdaa4bc/attachment.htm>