[asterisk-dev] [Code Review] chan_jingle2: New Jingle + Google Talk channel driver
Paul Belanger
reviewboard at asterisk.org
Fri Jun 15 11:23:42 CDT 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1917/#review6488
-----------------------------------------------------------
/trunk/channels/chan_jingle2.c
<https://reviewboard.asterisk.org/r/1917/#comment12253>
assumed?
/trunk/channels/chan_jingle2.c
<https://reviewboard.asterisk.org/r/1917/#comment12254>
braces
/trunk/channels/chan_jingle2.c
<https://reviewboard.asterisk.org/r/1917/#comment12255>
same comment about break?
/trunk/channels/chan_jingle2.c
<https://reviewboard.asterisk.org/r/1917/#comment12256>
invert logic to reduce indent
/trunk/channels/chan_jingle2.c
<https://reviewboard.asterisk.org/r/1917/#comment12257>
again, invert?
/trunk/channels/chan_jingle2.c
<https://reviewboard.asterisk.org/r/1917/#comment12258>
same
/trunk/res/res_rtp_asterisk.c
<https://reviewboard.asterisk.org/r/1917/#comment12259>
eep
/trunk/res/res_rtp_asterisk.c
<https://reviewboard.asterisk.org/r/1917/#comment12260>
invert?
- Paul
On June 8, 2012, 3:32 p.m., Joshua Colp wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1917/
> -----------------------------------------------------------
>
> (Updated June 8, 2012, 3:32 p.m.)
>
>
> Review request for Asterisk Developers.
>
>
> Summary
> -------
>
> This is a new channel driver written from scratch for the Jingle, Google Jingle, and Google Talk protocols. It has been written to the specs available and tested extensively.
>
> ICE and STUN support for Jingle uses the new ICE/STUN/TURN support which is present in another review. (Please do not review any of that code in this review)
> STUN support for Google uses the existing STUN implementation, as the new support is not compatible with it.
>
>
> Diffs
> -----
>
> /trunk/channels/chan_jingle2.c PRE-CREATION
> /trunk/channels/chan_sip.c 368682
> /trunk/configs/jingle2.conf.sample PRE-CREATION
> /trunk/configs/rtp.conf.sample 368682
> /trunk/include/asterisk/jabber.h 368682
> /trunk/include/asterisk/jingle.h 368682
> /trunk/include/asterisk/rtp_engine.h 368682
> /trunk/main/rtp_engine.c 368682
> /trunk/res/Makefile 368682
> /trunk/res/res_jabber.c 368682
> /trunk/res/res_rtp_asterisk.c 368682
>
> Diff: https://reviewboard.asterisk.org/r/1917/diff
>
>
> Testing
> -------
>
> Tested audio calls with following:
>
> GMail Google Talk Plug-in (and video)
> Google Voice
> Jitsi (and video)
> Psi
> OneTeam
>
> * Included varying codecs (ulaw, speex, g722, etc)
>
> Tested ringing, hold, and unhold with following:
>
> Jitsi
>
> Other clients do not support this.
>
>
> Thanks,
>
> Joshua
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120615/85a372cc/attachment-0001.htm>
More information about the asterisk-dev
mailing list