[asterisk-dev] [Code Review]: [confbridge] Behavioural correction for hold-music state when users join/part conferences in varying combinations

[Neil Tallim]

> On May 17, 2012, 8:39 a.m., Matt Jordan wrote:
> > /trunk/apps/app_confbridge.c, lines 825-826
> > <https://reviewboard.asterisk.org/r/1869/diff/1/?file=27305#file27305line825>
> >
> >     Don't put brackets on a line by themselves

Unrelated to this comment, but noted here so I can simplify things when building the next iteration of this patch: this can be reduced to "if (!conference_bridge->markedusers) {" with a nested inner check for MUSICONHOLD (has to be inner to simplify muting logic).

I missed one of the pre-conditions for the function being invoked and introduced a check for something established in the environment when I could have actually made it easier.


- Neil


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1869/#review6231
-----------------------------------------------------------


On May 9, 2012, 4:35 p.m., Neil Tallim wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1869/
> -----------------------------------------------------------
> 
> (Updated May 9, 2012, 4:35 p.m.)
> 
> 
> Review request for Asterisk Developers, David Vossel and jcolp.
> 
> 
> Summary
> -------
> 
> This is the "everything" patch attached to issue https://issues.asterisk.org/jira/browse/ASTERISK-19562
> 
> Details about what it does may be found in the issue's description.
> 
> 
> Diffs
> -----
> 
>   /trunk/apps/app_confbridge.c 359977 
> 
> Diff: https://reviewboard.asterisk.org/r/1869/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Neil
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120614/b7f15caa/attachment-0001.htm>