[asterisk-dev] [Code Review] Fix NULL pointer segfault in ast_sockaddr_parse()

[Simon Perreault]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1990/#review6478
-----------------------------------------------------------

Ship it!


Ok, but please also document this in netsock2.h.

- Simon


On June 14, 2012, 8:35 p.m., elguero wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1990/
> -----------------------------------------------------------
> 
> (Updated June 14, 2012, 8:35 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> While working with ast_parse_arg() in order to perform a validity check, there was a segfault.
> 
> The segfault occurs due to passing a NULL pointer to ast_sockaddr_parse() and then that function tries to set the address.
> 
> According to config.h, "result pointer to the result. NULL is valid here, and can be used to perform only the validity checks."
> 
> This needs to go in to the code base before committing the manager ipv6 code.
> 
> 
> This addresses bug ASTERISK-20006.
>     https://issues.asterisk.org/jira/browse/ASTERISK-20006
> 
> 
> Diffs
> -----
> 
>   /branches/1.8/main/netsock2.c 368091 
> 
> Diff: https://reviewboard.asterisk.org/r/1990/diff
> 
> 
> Testing
> -------
> 
> Local dev machines
> 
> 
> Thanks,
> 
> elguero
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120615/edd1edab/attachment.htm>