[asterisk-dev] [Code Review] Add IAX2 support for the new HANGUPCAUSE hash

Matt Jordan reviewboard at asterisk.org
Thu Jun 14 16:25:21 CDT 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1941/#review6474
-----------------------------------------------------------

Ship it!


Nice work!


trunk/main/frame.c
<https://reviewboard.asterisk.org/r/1941/#comment12221>

    It looks like this is missing an indentation.


- Matt


On May 24, 2012, 3:34 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1941/
> -----------------------------------------------------------
> 
> (Updated May 24, 2012, 3:34 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Add the IAX2 implementation of the "Who Hung Up?" work for Asterisk 11.  Numeric cause codes are provided for messages in which they're expected.  Additionally, methods of generating descriptions of frame types and subclasses have been exposed.
> 
> 
> This addresses bug SWP-4222.
>     https://issues.asterisk.org/jira/browse/SWP-4222
> 
> 
> Diffs
> -----
> 
>   trunk/channels/chan_iax2.c 367194 
>   trunk/include/asterisk/frame.h 367194 
>   trunk/main/frame.c 367194 
> 
> Diff: https://reviewboard.asterisk.org/r/1941/diff
> 
> 
> Testing
> -------
> 
> See tests in Review 1942.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120614/9a740dcc/attachment.htm>


More information about the asterisk-dev mailing list