[asterisk-dev] [Code Review]: named_acls: Named ACLs - a system for creating and applying ACLs with named profiles which can be shared

[Kevin Fleming]

> On June 7, 2012, 1:10 p.m., jcolp wrote:
> > /trunk/main/named_acl.c, line 8
> > <https://reviewboard.asterisk.org/r/1978/diff/1/?file=28618#file28618line8>
> >
> >     Pfft! Wilson not wilson.
> 
> jrose wrote:
>     fixed
> 
> Kevin Fleming wrote:
>     This entire file header needs to be replaced with something much closer to our standard file header. We don't provide attribution to people who wrote other parts of Asterisk in a file that uses them, and we don't put file version numbers and dates in the header either. It is also very important that the file header include the licensing statements present in the standard file header.
> 
> jrose wrote:
>     /*
>      * Asterisk -- A telephony toolkit for Linux.
>      *
>      * Copyright (C) 2012, Digium, Inc.
>      *
>      * Mark Spencer <markster at digium.com>
>      *
>      * See http://www.asterisk.org for more information about
>      * the Asterisk project. Please do not directly contact
>      * any of the maintainers of this project for assistance;
>      * the project provides a web site, mailing lists and IRC
>      * channels for your use.
>      *
>      * This program is free software, distributed under the terms of
>      * the GNU General Public License Version 2. See the LICENSE file
>      * at the top of the source tree.
>      */
>     
>     /*! \file
>      *
>      * \brief Named Access Control Lists
>      *
>      * \author Jonathan Rose <jrose at digium.com>
>      *
>      * \note Based on a feature proposed and prototyped by
>      * Olle E. Johansson <oej at edvina.net>
>      */
>     
>     I'm not sure if that's adequate or not.

Yes, that's fine, and it's OK to list yourself as the other in the first comment block as well, since you are the primary author of the code in this file.


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1978/#review6409
-----------------------------------------------------------


On June 8, 2012, 2:04 p.m., jrose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1978/
> -----------------------------------------------------------
> 
> (Updated June 8, 2012, 2:04 p.m.)
> 
> 
> Review request for Asterisk Developers, Mark Michelson, Terry Wilson, and Olle E Johansson.
> 
> 
> Summary
> -------
> 
> This feature is based on oej's deluxepine (or something like that) branch with a similarly named feature.  ACLs are defined in acl.conf and can be used by pretty much anything that has ACL options permit/deny (acl='aclname').  acl= works similarly to permit= and deny= in that it simply appends to the working ACL, so they can be combined with other uses of permit/deny/acl.
> 
> Also in use in this patch are twilson's new config options.
> 
> Since named acls are duplicated when used in another configuration, configurations that use named acls need to be updated if acl.conf is reloaded. This is accomplished with a new event type and the consumption of that event is demonstrated currently only in manager.conf
> If this seems like a proper approach to this problem, that will be replicated across other consumers of named acls.
> 
> NOTE: This code is very much WIP and not intended for merging.
> 
> 
> Diffs
> -----
> 
>   /trunk/CHANGES 368662 
>   /trunk/channels/chan_h323.c 368662 
>   /trunk/channels/chan_iax2.c 368662 
>   /trunk/channels/chan_mgcp.c 368662 
>   /trunk/channels/chan_sip.c 368662 
>   /trunk/channels/chan_skinny.c 368662 
>   /trunk/channels/chan_unistim.c 368662 
>   /trunk/configs/acl.conf.sample PRE-CREATION 
>   /trunk/configs/iax.conf.sample 368662 
>   /trunk/configs/manager.conf.sample 368662 
>   /trunk/configs/sip.conf.sample 368662 
>   /trunk/configs/skinny.conf.sample 368662 
>   /trunk/include/asterisk/acl.h 368662 
>   /trunk/include/asterisk/event_defs.h 368662 
>   /trunk/main/acl.c 368662 
>   /trunk/main/asterisk.c 368662 
>   /trunk/main/manager.c 368662 
>   /trunk/main/named_acl.c PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/1978/diff
> 
> 
> Testing
> -------
> 
> Various tests for configuring and using named acls were performed, and a task for writing comprehensive testsuite tests is in the queue.  Additionally, various means of reloading the configuration have been performed, and so far they pan out aside from a bug with an unchanged acl.conf which is a generic problem against config options accidentally introduced a little while back.
> 
> 
> Thanks,
> 
> jrose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120611/562ab6fc/attachment-0001.htm>