[asterisk-dev] [Code Review]: Patch to detect/parse ANI-II / ANI2 / OLI from SIP INVITE messages

[Rob Gagnon]

> On June 11, 2012, 3:50 p.m., opticron wrote:
> > /trunk/channels/chan_sip.c, lines 24241-24246
> > <https://reviewboard.asterisk.org/r/1947/diff/7/?file=28867#file28867line24241>
> >
> >     It's a good idea to preceed these tags with a ';' to prevent unwanted matches and update the offsets accordingly.

Done.  I had left off the semi's to account for the possible mis-formatted tag containing a space after the semi-colon...  It now appears the only place chan_sip watches for mis-placed spaces is in find_sdp() when parsing the "Content-type" header looking for the "boundary" tag.


- Rob


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1947/#review6444
-----------------------------------------------------------


On June 11, 2012, 4:20 p.m., Rob Gagnon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1947/
> -----------------------------------------------------------
> 
> (Updated June 11, 2012, 4:20 p.m.)
> 
> 
> Review request for Asterisk Developers, Mark Michelson, rmudgett, opticron, and Rob Gagnon.
> 
> 
> Summary
> -------
> 
> Add ANI2 / OLI parsing for SIP.  The patch checks the "From" header during the handle_request_invite() function for the presence of "isup-oli", "ss7-oli", or "oli" tags.  If present, the up-to-2-digits following the equal sign in the tag are set on the channel's caller structure in the "ani2" int element.
> 
> This allows SIP functions that reference ANI2 to work properly for SIP.  Specifically tested was the messaging that occurs when AGI transmits its data to an AGI script.
> 
> 
> This addresses bug ASTERISK-19912.
>     https://issues.asterisk.org/jira/browse/ASTERISK-19912
> 
> 
> Diffs
> -----
> 
>   /trunk/channels/chan_sip.c 368780 
> 
> Diff: https://reviewboard.asterisk.org/r/1947/diff
> 
> 
> Testing
> -------
> 
> Call processing via AGI call in dial plan which logs all AGI incoming values was executed from cell phone, land line, and payphone.  During the payphone call, the value of "agi_callingani2" was properly transmitted as "7" for the payphone, "62" for the cell phone, and "0" for the landline.
> 
> Over 600,000 calls have been processed in 12 hours or more of testing without errors.
> 
> 
> Thanks,
> 
> Rob
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120611/514e4eb8/attachment-0001.htm>