[asterisk-dev] [Code Review] Fix reloading an unchanged file with the Config Options API
Terry Wilson
reviewboard at asterisk.org
Thu Jun 7 10:59:25 CDT 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1979/
-----------------------------------------------------------
Review request for Asterisk Developers and jrose.
Summary
-------
Adding multiple file support broke reloading unchanged files. This patch adds an enum for the return value of the aco_process functions and uses those values to ensure that the apply_config function is not called when the config is unchanged.
Diffs
-----
/trunk/main/config_options.c 368663
/trunk/include/asterisk/config_options.h 368663
/trunk/apps/app_skel.c 368663
/trunk/main/udptl.c 368663
/trunk/tests/test_config.c 368663
Diff: https://reviewboard.asterisk.org/r/1979/diff
Testing
-------
Tests passed, did some reloads. All is well.
Thanks,
Terry
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120607/853562c5/attachment.htm>
More information about the asterisk-dev
mailing list