[asterisk-dev] chan_mobile: port auto-detection

[Lawrence Conroy]

Hi Matthew, Stefan, folks,

I looked at the (small) patch even without any license being signed.
I had kinda assumed I was part of "the Asterisk developer Community" -- that's why I sub to this list.

=> The intro and (b) seem wrong as phrased.

It may well not make it into the digium-maintained code base without a signed release/license, but ...
 anyone could apply it and test it. This is an open source project, right?

all the best,
  Lawrence

On 6 Jun 2012, at 18:39, Matthew Jordan wrote:
> Hello -
> 
> In order for the Asterisk developer community to look at your patch,
> you'll need to:
> 
> a) Create a new issue in the issue tracker here:
> https://issues.asterisk.org/jira/
> 
> b) Sign a License Agreement.  Until this is signed, the Asterisk developer
> community will not examine your patch. 
> 
> c) Since your patch is a new feature, you should attach a unified diff
> against trunk on the JIRA issue.
> 
> Thanks
> 
> --
> Matthew Jordan
> Digium, Inc. | Software Developer
> 445 Jan Davis Drive NW - Huntsville, AL 35806 - USA
> Check us out at: http://digium.com & http://asterisk.org
> 
> ----- Original Message -----
>> From: "Stefan Schmidt" <ihacworx at gmx.net>
>> To: asterisk-dev at lists.digium.com
>> Sent: Wednesday, June 6, 2012 12:21:48 PM
>> Subject: [asterisk-dev] chan_mobile: port auto-detection
>> 
>> Hello,
>> first of all I am new to this list, so I'd like to say thank you to
>> everyone for creating, maintaining and updating asterisk with all
>> sorts of features.
>> 
>> Now, my main topic is chan_mobile, which requires the user to enter a
>> port number in the config file. At the same time, the module
>> provides a run-time command to find out the right port. As my mobile
>> (Nokia N8, Symbian Belle) seems to change the port number after
>> every reboot, I considered that it would be nice if chan_mobile
>> would try and detect the right setting on its own.
>> With the attached patch (written and tested with Debian version
>> 1.8.11.1~dfsg-1 but also applies against trunk), the code uses the
>> auto-detect feature if you leave the "port" setting out of the
>> config file. I am looking forward to hearing your feedback.
>> 
>> While I was at it, I noticed the member "rport" in the hfp_pvt
>> struct. However, it is only assigned a value in mbl_load_device, but
>> I couldn't see it being used throughout the code. Therefore, I
>> didn't bother updating it to the right value in my patch. Does
>> anyone know its purpose?
>> 
>> Best regards,
>> Stefan
>> 
>> 
>> --
>> _____________________________________________________________________
>> -- Bandwidth and Colocation Provided by http://www.api-digital.com --
>> 
>> asterisk-dev mailing list
>> To UNSUBSCRIBE or update options visit:
>>   http://lists.digium.com/mailman/listinfo/asterisk-dev
> 
> --
> _____________________________________________________________________
> -- Bandwidth and Colocation Provided by http://www.api-digital.com --
> 
> asterisk-dev mailing list
> To UNSUBSCRIBE or update options visit:
>   http://lists.digium.com/mailman/listinfo/asterisk-dev