[asterisk-dev] [Code Review] Remove global module flag from app_voicemail.

[Jason Parker]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1965/
-----------------------------------------------------------

(Updated June 5, 2012, 12:58 p.m.)


Review request for Asterisk Developers and Mark Michelson.


Changes
-------

Turns out, the function to get a folder name really is useful.


Summary
-------

This causes app_voicemail to register functions that were previously global, in the same way that other functions are already registered.

The API changes a bit, but callers will only need to make a minor change, as the number of folders is no longer static.


Diffs (updated)
-----

  /certified/branches/1.8.11/apps/app_voicemail.c 368244 
  /certified/branches/1.8.11/include/asterisk/app.h 368244 
  /certified/branches/1.8.11/include/asterisk/app_voicemail.h 368244 
  /certified/branches/1.8.11/main/app.c 368244 
  /certified/branches/1.8.11/tests/test_voicemail_api.c 368244 

Diff: https://reviewboard.asterisk.org/r/1965/diff


Testing
-------

It compiles, and functions can be called the same way they are today.


Thanks,

Jason

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120605/c91c18ed/attachment.htm>