[asterisk-dev] [Code Review] Update Data of Queues (use queues as outbound calls container)

[Paul Belanger]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1958/#review6380
-----------------------------------------------------------


This fails to compile on the latest trunk.




trunk/apps/app_queue.c
<https://reviewboard.asterisk.org/r/1958/#comment11920>

    tabbing



trunk/apps/app_queue.c
<https://reviewboard.asterisk.org/r/1958/#comment11921>

    if (...) {



trunk/apps/app_queue.c
<https://reviewboard.asterisk.org/r/1958/#comment11922>

    This else can be remove, and everything move to the left by 1 tab



trunk/apps/app_queue.c
<https://reviewboard.asterisk.org/r/1958/#comment11923>

    if (...) {



trunk/apps/app_queue.c
<https://reviewboard.asterisk.org/r/1958/#comment11924>

    same and tabbing



trunk/apps/app_queue.c
<https://reviewboard.asterisk.org/r/1958/#comment11925>

    same



trunk/apps/app_queue.c
<https://reviewboard.asterisk.org/r/1958/#comment11926>

    } else {


- Paul


On June 4, 2012, 2:49 p.m., sum wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1958/
> -----------------------------------------------------------
> 
> (Updated June 4, 2012, 2:49 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> this adds a new dialplan function QueueUpdate, with this is possible using it at h exten to have Outbound queues.
> 
> The idea is to be able to track in realtime outbound calls (completed, canceled) this will also log a new event on queue_log OUTCALL
> that has information about these calls.
> 
> has to be invoked on h exten
> 
> https://issues.asterisk.org/jira/browse/ASTERISK-19862
> 
> 
> Diffs
> -----
> 
>   trunk/apps/app_queue.c 368420 
> 
> Diff: https://reviewboard.asterisk.org/r/1958/diff
> 
> 
> Testing
> -------
> 
> compile on trunk
> heavily tested on 1.8.X and 1.6.2.X
> 
> 
> Thanks,
> 
> sum
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120604/25a3e54c/attachment-0001.htm>