[asterisk-dev] [Code Review]: Changes from Mantis ID 13495 in trunk.

[KNK]

> On July 25, 2012, 1:32 p.m., rmudgett wrote:
> > trunk/channels/chan_dahdi.c, lines 15571-15572
> > <https://reviewboard.asterisk.org/r/1676/diff/6-7/?file=29255#file29255line15571>
> >
> >     Keep FORMAT2 in case FORMAT and FORMAT2 ever become different.  It certainly doesn't do any harm keeping FORMAT2.

Done.


> On July 25, 2012, 1:32 p.m., rmudgett wrote:
> > trunk/channels/chan_dahdi.c, line 16738
> > <https://reviewboard.asterisk.org/r/1676/diff/6-7/?file=29255#file29255line16738>
> >
> >     This expression is dependent upon the caller passing in 0/1 for the do_block parameter.  Any other value will cause this expression to fail.  To make this expression less fragile:
> >     if (!!do_block ^ !(...)) {
> >     }

I have already redesigned the function to internally set do_block based on the command executed, but proper checking will not harm - done.


- KNK


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1676/#review6806
-----------------------------------------------------------


On July 24, 2012, 2:09 p.m., KNK wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1676/
> -----------------------------------------------------------
> 
> (Updated July 24, 2012, 2:09 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> chan_dahdi / sig_ss7 part of changes
> 
> 
> This addresses bug SS7-27.
>     https://issues.asterisk.org/jira/browse/SS7-27
> 
> 
> Diffs
> -----
> 
>   trunk/channels/chan_dahdi.c 370452 
>   trunk/channels/sig_ss7.h 370452 
>   trunk/channels/sig_ss7.c 370452 
> 
> Diff: https://reviewboard.asterisk.org/r/1676/diff
> 
> 
> Testing
> -------
> 
> compiles, link setup, cli commands, bassic calls, connected line and redirection.
> 
> 
> Thanks,
> 
> KNK
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120727/c1d398c5/attachment.htm>