[asterisk-dev] [Code Review] Add NO ANSWER CEL/CDR tests for Queue

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2063/
-----------------------------------------------------------

Review request for Asterisk Developers.


Summary
-------

This patch adds three tests for Queue that verify CDR/CEL records when a user is in a queue and no one answers:

1. It verifies that if you have multiple agents and they ignore the caller, the CDR disposition is NO ANSWER
2. It verifies that if you have multiple agents, one being paused, and the other ignores the caller, the CDR disposition is NO ANSWER (this currently fails in 1.8+ - the disposition is BUSY - see https://reviewboard.asterisk.org/r/2064)
3. It verifies that if you have multiple agents and they are all paused, that the CDR disposition is NO ANSWER

In all three scenarios, we verify the creation of the appropriate CHAN_START, APP_START, APP_END, and CHAN_END events.

Note that as an improvement to the cdr/cel pluggable modules, we now allow a record to be 'skipped' in the CDR/CEL files under test by specifying a blank line in the expected CDR/CEL results.  While these tests don't currently use that feature, it was useful in getting certain tests set up, and could be useful in the future if you only want to know the expected result of the last entry in the CDR/CEL record (or if you have several CDR/CEL records that you don't care about and that can arrive in any order).


This addresses bug AST-906.
    https://issues.asterisk.org/jira/browse/AST-906


Diffs
-----

  /asterisk/trunk/configs/cel.conf 3356 
  /asterisk/trunk/lib/python/asterisk/cdr.py 3356 
  /asterisk/trunk/lib/python/asterisk/cel.py 3356 
  /asterisk/trunk/tests/queues/queue_all_paused_no_answer/configs/ast1/cdr.conf PRE-CREATION 
  /asterisk/trunk/tests/queues/queue_all_paused_no_answer/configs/ast1/cel.conf PRE-CREATION 
  /asterisk/trunk/tests/queues/queue_all_paused_no_answer/configs/ast1/extensions.conf PRE-CREATION 
  /asterisk/trunk/tests/queues/queue_all_paused_no_answer/configs/ast1/queues.conf PRE-CREATION 
  /asterisk/trunk/tests/queues/queue_all_paused_no_answer/test-config.yaml PRE-CREATION 
  /asterisk/trunk/tests/queues/queue_no_answer/configs/ast1/cdr.conf PRE-CREATION 
  /asterisk/trunk/tests/queues/queue_no_answer/configs/ast1/cel.conf PRE-CREATION 
  /asterisk/trunk/tests/queues/queue_no_answer/configs/ast1/extensions.conf PRE-CREATION 
  /asterisk/trunk/tests/queues/queue_no_answer/configs/ast1/queues.conf PRE-CREATION 
  /asterisk/trunk/tests/queues/queue_no_answer/test-config.yaml PRE-CREATION 
  /asterisk/trunk/tests/queues/queue_one_paused_no_answer/configs/ast1/cdr.conf PRE-CREATION 
  /asterisk/trunk/tests/queues/queue_one_paused_no_answer/configs/ast1/cel.conf PRE-CREATION 
  /asterisk/trunk/tests/queues/queue_one_paused_no_answer/configs/ast1/extensions.conf PRE-CREATION 
  /asterisk/trunk/tests/queues/queue_one_paused_no_answer/configs/ast1/queues.conf PRE-CREATION 
  /asterisk/trunk/tests/queues/queue_one_paused_no_answer/test-config.yaml PRE-CREATION 
  /asterisk/trunk/tests/queues/tests.yaml 3357 

Diff: https://reviewboard.asterisk.org/r/2063/diff


Testing
-------


Thanks,

Matt

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120725/e04b96fe/attachment.htm>