[asterisk-dev] [Code Review] SHELLEX() dialplan function

[Kevin Fleming]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2061/#review6807
-----------------------------------------------------------



/trunk/funcs/func_shell.c
<https://reviewboard.asterisk.org/r/2061/#comment13090>

    Since this function can return an error code, I think it would be more useful if it did *not* stop dialplan execution on errors.



/trunk/funcs/func_shell.c
<https://reviewboard.asterisk.org/r/2061/#comment13085>

    This loop is going to consume a rather large amount of CPU time since nothing in it will block.



/trunk/funcs/func_shell.c
<https://reviewboard.asterisk.org/r/2061/#comment13087>

    What is this? This has nothing to do with ODBC.


- Kevin


On July 24, 2012, 10:50 a.m., Tilghman Lesher wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2061/
> -----------------------------------------------------------
> 
> (Updated July 24, 2012, 10:50 a.m.)
> 
> 
> Review request for Asterisk Developers and Kevin Fleming.
> 
> 
> Summary
> -------
> 
> Following a discussion about capturing the return value as well as the output of a command, I came up with this.
> 
> 
> Diffs
> -----
> 
>   /trunk/funcs/func_shell.c 370407 
> 
> Diff: https://reviewboard.asterisk.org/r/2061/diff
> 
> 
> Testing
> -------
> 
> Compile testing only
> 
> 
> Thanks,
> 
> Tilghman
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120725/8973ad47/attachment-0001.htm>