[asterisk-dev] [Code Review]: Bring the (missing) changes from Mantis ID 13495 in trunk.

[rmudgett]

> On July 24, 2012, 10:59 a.m., rmudgett wrote:
> > branches/1.0/isup.c, lines 1169-1171
> > <https://reviewboard.asterisk.org/r/1653/diff/15-16/?file=30537#file30537line1169>
> >
> >     You only need to initialize the last octet in the bit array.  Initializing all of them is a waste because you are setting each bit individually.
> >     
> >     if (numcics) {
> >         parm[1 + (numcics - 1) / 8] = '\0';
> >     }
> >     for () {
> >     }
> 
> KNK wrote:
>     Maybe i am not getting it, but the bits are only set to 1 "if (c->status[i]) " but not set to 0 otherwise.
>

Oh.  Yes, you are correct.  I was missing the fact that nothing was setting bits to zero.


> On July 24, 2012, 10:59 a.m., rmudgett wrote:
> > branches/1.0/mtp3.h, line 151
> > <https://reviewboard.asterisk.org/r/1653/diff/15-16/?file=30541#file30541line151>
> >
> >     If you remove the semicolon too, when you use AUTORL(rl, link) you then have to put the semicolon where is is used:
> >     AUTORL(rl, link);
> >     
> >     The macro then looks like a function and requires a semicolon like any other function.
> 
> KNK wrote:
>     Actually there is ; after each use and there is no need to remove it, but let me know if i should.

Removing the semicolon in the macro definition makes the semicolon required where AUTORL is used.  As it is, the semicolon could be omitted where it is used and still compile.  Omitting the semicolon where used then makes the code look odd.


- rmudgett


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1653/#review6795
-----------------------------------------------------------


On July 24, 2012, 8:52 a.m., KNK wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1653/
> -----------------------------------------------------------
> 
> (Updated July 24, 2012, 8:52 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> libss7 part of the changes.
> Added additional cause codes, Transmission Medium Requirement setting and connected line to CPG messages + code cleanup.
> 
> 
> This addresses bugs SS7-21, SS7-27, SS7-28, SS7-33, SS7-36, SS7-38, SS7-39, SS7-40, SS7-42, SS7-43, SS7-45, SS7-46, SS7-47, SS7-48, SS7-49, SS7-51, SS7-52, SS7-53, SS7-54, and SS7-7.
>     https://issues.asterisk.org/jira/browse/SS7-21
>     https://issues.asterisk.org/jira/browse/SS7-27
>     https://issues.asterisk.org/jira/browse/SS7-28
>     https://issues.asterisk.org/jira/browse/SS7-33
>     https://issues.asterisk.org/jira/browse/SS7-36
>     https://issues.asterisk.org/jira/browse/SS7-38
>     https://issues.asterisk.org/jira/browse/SS7-39
>     https://issues.asterisk.org/jira/browse/SS7-40
>     https://issues.asterisk.org/jira/browse/SS7-42
>     https://issues.asterisk.org/jira/browse/SS7-43
>     https://issues.asterisk.org/jira/browse/SS7-45
>     https://issues.asterisk.org/jira/browse/SS7-46
>     https://issues.asterisk.org/jira/browse/SS7-47
>     https://issues.asterisk.org/jira/browse/SS7-48
>     https://issues.asterisk.org/jira/browse/SS7-49
>     https://issues.asterisk.org/jira/browse/SS7-51
>     https://issues.asterisk.org/jira/browse/SS7-52
>     https://issues.asterisk.org/jira/browse/SS7-53
>     https://issues.asterisk.org/jira/browse/SS7-54
>     https://issues.asterisk.org/jira/browse/SS7-7
> 
> 
> Diffs
> -----
> 
>   branches/1.0/libss7.h 306 
>   branches/1.0/mtp2.h 306 
>   branches/1.0/mtp2.c 306 
>   branches/1.0/mtp3.h 306 
>   branches/1.0/mtp3.c 306 
>   branches/1.0/isup.h 306 
>   branches/1.0/isup.c 306 
>   branches/1.0/parser_debug.c 306 
>   branches/1.0/ss7.c 306 
>   branches/1.0/ss7_internal.h 306 
>   branches/1.0/ss7linktest.c 306 
>   branches/1.0/ss7test.c 306 
> 
> Diff: https://reviewboard.asterisk.org/r/1653/diff
> 
> 
> Testing
> -------
> 
> compiles, link setup, cli commands, bassic calls, connected line and redirection
> 
> 
> Thanks,
> 
> KNK
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120724/a9900200/attachment-0001.htm>