[asterisk-dev] [Code Review] Abstract Jitter Buffer API Unit Tests

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2035/#review6784
-----------------------------------------------------------

Ship it!


- Mark


On July 12, 2012, 3:17 p.m., Matt Jordan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2035/
> -----------------------------------------------------------
> 
> (Updated July 12, 2012, 3:17 p.m.)
> 
> 
> Review request for Asterisk Developers and Mark Michelson.
> 
> 
> Summary
> -------
> 
> This patch pulls over the unit test from the now defunct DTMF jitter buffer patch.  It includes the following:
> 
> * Tweaks to the abstract_jb API to remove the unnecessary resync_threshold parameter from the create function (resync_threshold is already in the struct passed into the create function)
> * Ensure the fixed jitter buffer is empty before destroying it, to avoid an ASSERT
> * Don't "resync" the adaptive jitter buffer.  The mechanism that was being used actually causes the jitter buffer to think its being overflowed by going around the jitterbuf API and attempting to 'resynch' it improperly.  If a resync is needed, the jitter buffer will do it properly by itself.  Note that this is only an optimization needed for trunk, as the worst that happens is the loss of three voice packets before the adaptive jitter buffer will resync anyway (but it does cause the unit tests to fail, as the first packet in gets treated as an overflow).
> 
> This pulls over the unit tests for the abstract_jb, removing the DTMF portions.
> 
> 
> Diffs
> -----
> 
>   /trunk/funcs/func_jitterbuffer.c 370013 
>   /trunk/include/asterisk/abstract_jb.h 370013 
>   /trunk/main/abstract_jb.c 370013 
>   /trunk/tests/test_abstract_jb.c PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/2035/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Matt
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120723/7bb77f53/attachment.htm>