[asterisk-dev] [Code Review]: chan_iax2 consumption test for ACLs

[jrose]

> On July 23, 2012, 10:25 a.m., opticron wrote:
> > /asterisk/trunk/tests/iax2/acl_call/run-test, line 14
> > <https://reviewboard.asterisk.org/r/2046/diff/2/?file=30345#file30345line14>
> >
> >     logger should be LOGGER since it's a global.

Fixed.  Changed for channels/SIP/acl_call and manager/acl-call as well.


- jrose


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2046/#review6773
-----------------------------------------------------------


On July 17, 2012, 2:10 p.m., jrose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2046/
> -----------------------------------------------------------
> 
> (Updated July 17, 2012, 2:10 p.m.)
> 
> 
> Review request for Asterisk Developers, Mark Michelson, opticron, and Matt Jordan.
> 
> 
> Summary
> -------
> 
> Just like the SIP test, only Iaxy.
> 
> Tests calls made with IAX2 peers using different addresses against different ACLs.  Includes tests for the following:
> 
> 1. Single ACL set via permit/deny
> 2. Single ACL set via acl=named_acl
> 3. Multiple ACLs set via acl=named_acl1,named_acl2,...
> 4. A bad ACL set via acl=<unavailable ACL name>
> 5. Multiple ACLs set from a realtime SQLite3 db via acl=realtime1,realtime2,...
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/iax2/acl_call/configs/ast1/acl.conf PRE-CREATION 
>   /asterisk/trunk/tests/iax2/acl_call/configs/ast1/extconfig.conf PRE-CREATION 
>   /asterisk/trunk/tests/iax2/acl_call/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/iax2/acl_call/configs/ast1/iax.conf PRE-CREATION 
>   /asterisk/trunk/tests/iax2/acl_call/configs/ast1/modules.conf PRE-CREATION 
>   /asterisk/trunk/tests/iax2/acl_call/configs/ast1/res_config_sqlite3.conf PRE-CREATION 
>   /asterisk/trunk/tests/iax2/acl_call/realtime.sqlite3 UNKNOWN 
>   /asterisk/trunk/tests/iax2/acl_call/run-test PRE-CREATION 
>   /asterisk/trunk/tests/iax2/acl_call/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/iax2/tests.yaml 3312 
> 
> Diff: https://reviewboard.asterisk.org/r/2046/diff
> 
> 
> Testing
> -------
> 
> 1. Ran the test itself and made sure the expected log messages appeared
> 2. Changed some test expectations to see how it would handle results differing from expectations.
> 
> 
> Thanks,
> 
> jrose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120723/852eeb46/attachment-0001.htm>