[asterisk-dev] [Code Review] Dialplan function for manager account checks - AMI_CLIENT()

[Andrew Latham]

On Thu, Jul 19, 2012 at 11:42 AM, Matthew  Jordan <mjordan at digium.com> wrote:
>
> ----- Original Message -----
>
>> From: "Terry Wilson" <reviewboard at asterisk.org>
>> To: "Terry Wilson" <reviewboard at asterisk.org>, "Asterisk Developers"
>> <asterisk-dev at lists.digium.com>, "Olle E Johansson" <oej at edvina.net>
>> Sent: Thursday, June 14, 2012 2:31:59 PM
>> Subject: Re: [asterisk-dev] [Code Review] Dialplan function for
>> manager account checks - AMI_CLIENT()
>
> Hey Olle -
>
> Minus Terry's documentation suggest, this is ready to go.  If you don't have
> time right now, do you want us to go ahead and make the documentation improvement
> Terry suggested and commit it for Asterisk 11?
>
>> Ship it! Looks like it still applies cleanly to trunk. With the minor
>> documentation change, I say ship It.
>
>> /trunk/main/manager.c (Diff revision 4)
>> ASTERISK_FILE_VERSION(__FILE__, "$Revision$")
>> 834   <parameter name="parameter" required="true">
>> 835   <para>Attribute to login name to return.
>> 836   </para>
>> 837   </parameter> I think a good way to document this would be like I
>> did in res_calendar:
>
>> <parameter name="field" required="true">
>> <enumlist>
>> <enum name="sessions"><para>The number of sessions for this AMI
>> account</para></enum>
>> </enumlist>
>> </parameter>
>
>
> Matt
>
> --
> Matthew Jordan
> Digium, Inc. | Software Developer
> 445 Jan Davis Drive NW - Huntsville, AL 35806 - USA
> Check us out at: http://digium.com & http://asterisk.org

Matt

Olle is on vacation right now.  Not sure if he is checking his mail.


-- 
~ Andrew "lathama" Latham lathama at gmail.com http://lathama.net ~