[asterisk-dev] [Code Review] Resolve severe memory leak in CEL logging modules.

[Kevin Fleming]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2053/
-----------------------------------------------------------

Review request for Asterisk Developers.


Summary
-------

A customer reported a significant memory leak using Asterisk 1.8. They have tracked it down do ast_cel_fabricate_channel_from_event() in main/cel.c, which is called by both in-tree CEL logging modules (cel_custom.c and cel_sqlite3_custom.c) for each and every CEL event that they log.

The cause was an incorrect assumption about how data attached to an ast_channel would be handled when the channel is destroyed; the data is now stored in a datastore attached to the channel, which is destroyed along with the channel at the proper time.


Diffs
-----

  /branches/1.8/main/cel.c 370182 

Diff: https://reviewboard.asterisk.org/r/2053/diff


Testing
-------

Compile testing only.


Thanks,

Kevin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120718/1487f198/attachment.htm>