[asterisk-dev] [Code Review] chan_sip code cleanup

[gareth]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1993/
-----------------------------------------------------------

(Updated July 17, 2012, 6:35 p.m.)


Review request for Asterisk Developers.


Changes
-------

Updated diff, removed unused addr and e parameters which aren't used yet. 


Summary
-------

This is the first part split out from the much larger patch at https://reviewboard.asterisk.org/r/1976/ - it contains just the various chan_sip code cleanups.

- struct sip_refer converted to use the stringfields API.

- sip_{refer|notify}_allocate -> sip_{notify|refer}_alloc to match other *alloc functions.

- Replace get_msg_text, get_msg_text2 and get_pidf_body -> No, not get_pidf_msg_text_body3 but get_content, to match add_content.

- get_body doesn't get the request body, renamed to get_content_line.

- get_body_by_line doesn't get the body line, and is just a simple if test. Moved code inline and removed function.

- Remove camelCase in struct sip_peer peer state variables, onHold -> onhold, inUse -> inuse, inRinging -> ringing.

- Remove camelCase in struct sip_request rlPart1 -> rlpart1, rlPart2 -> rlpart2.

- Rename instances of pvt->randdata to pvt->nonce because that is what it is, no need to update struct sip_pvt because _it already has a nonce field_.

- Removed struct sip_pvt randdata stringfield.

- Remove useless (and inconsistent) 'header' suffix on variables in handle_request_subscribe.

- Use ast_strdupa on Event header in handle_request_subscribe to avoid overly complicated strncmp calls to find the event package.

- Move get_destination check in handle_request_subscribe to avoid duplicate checking for packages that don't need it.

- Move extension state callback management in handle_request_subscribe to avoid duplicate checking for packages that don't need it.

- Remove duplicate append_date prototype.

- Rename append_date -> add_date to match other add_xxx functions.

- Added add_expires helper function, removed code that manually added expires header.

- Remove _header suffix on add_diversion_header (no other header adding functions have this).

- Don't pass req->debug to request handle_request_XXXXX handlers if req is also being passed.

- Don't pass req->ignore to check_auth as req is already being passed.

- Don't create a subscription in handle_request_subscribe if p->expiry == 0.

- Don't walk of the back of referred_by_name when splitting string in get_refer_info

- Remove duplicate check for no dialog in handle_incoming when sipmethod == SIP_REFER, handle_request_refer checks for that.


Diffs (updated)
-----

  /trunk/channels/chan_sip.c 370151 
  /trunk/channels/sip/include/sip.h 370151 
  /trunk/channels/sip/security_events.c 370151 

Diff: https://reviewboard.asterisk.org/r/1993/diff


Testing
-------

It compiles.


Thanks,

gareth

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120717/2919b710/attachment.htm>